Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dependencies): Update non-breaking deps #293

Merged
merged 1 commit into from
Apr 2, 2018
Merged

chore(dependencies): Update non-breaking deps #293

merged 1 commit into from
Apr 2, 2018

Conversation

AllenBW
Copy link
Contributor

@AllenBW AllenBW commented Apr 2, 2018 •
edited
Loading

Updates all non-breaking deps, cept storybook cuz thats being done in #269

SO explaining what you're seeing here:

  • snapshots were updated, cuz patternfly was updated
  • a few linty things, cuz ✨
  • that one nasty .js

Good point made below, adding a storybook to this for convenience: https://AllenBW.github.io/patternfly-react/

@AllenBW AllenBW changed the title chore(dependencies): Update non-breaking deps [WIP] chore(dependencies): Update non-breaking deps Apr 2, 2018
dmiller9911
dmiller9911 reviewed Apr 2, 2018
View reviewed changes
package.json
"raf": "^3.4.0",
"react": "^16.2.0",
"react": "^16.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

dmiller9911
dmiller9911 previously approved these changes Apr 2, 2018
View reviewed changes
Copy link
Contributor

@dmiller9911 dmiller9911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@coveralls
Copy link

coveralls commented Apr 2, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1095

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.663%
Totals Coverage Status
Change from base Build 1094: 0.0%
Covered Lines: 1256
Relevant Lines: 1585
💛 - Coveralls

priley86
priley86 reviewed Apr 2, 2018
View reviewed changes
package.json
"patternfly": "^3.38.0",
"react-bootstrap": "^0.31.5",
"patternfly": "^3.42.0",
"react-bootstrap": "^0.32.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we definitely want to check for regressions on this one... amongst the others ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priley86 added storybook in first post 😋

@AllenBW
Copy link
Contributor Author

AllenBW commented Apr 2, 2018 •
edited
Loading

and yeah, we're suffering from jestjs/jest#5772 for a hot second...

curse you package-lock, #289 can't happen soon enough 😏

@AllenBW AllenBW changed the title [WIP] chore(dependencies): Update non-breaking deps chore(dependencies): Update non-breaking deps Apr 2, 2018
@priley86
Copy link
Member

priley86 commented Apr 2, 2018

did some preliminary looks... this is really nice...

  • storybook loads much much faster, both locally and on your rawgit 👍
  • breadcrumbs are fixed 👍

maybe we can start to investigate some other React 16.3 improvements in a future PR?

@jeff-phillips-18 jeff-phillips-18 merged commit b0786b8 into patternfly:master Apr 2, 2018
@AllenBW AllenBW deleted the chore/update-deps branch April 2, 2018 21:04
@priley86
Copy link
Member

priley86 commented Apr 2, 2018 •
edited
Loading

interestingly enough... travis build cache was failing something after all these dependency updates in Node 6... but clearing its cache fixed us ;)

for anyone needing to attempt this in the future in travis ... more options -> caches -> (delete master branch cache)... then restart build... 💚

i'm guessing this will be sparse though...

@priley86
Copy link
Member

priley86 commented Apr 2, 2018

thanks for the updates here @AllenBW @jeff-phillips-18 !!

@vojtechszocs vojtechszocs mentioned this pull request Apr 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priley86 priley86 priley86 approved these changes

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

@dmiller9911 dmiller9911 dmiller9911 left review comments

Assignees

@priley86 priley86

Labels
chore 🏠
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AllenBW @coveralls @priley86 @dmiller9911 @jeff-phillips-18